Skip to content

Conversation

chiayiseow
Copy link

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

pyproject.toml Outdated
"mkdocs-static-i18n>=1.3.0",
"eval-type-backport>=0.2.2",
"fastapi >= 0.110.0, <1",
"fastapi==0.109.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pinning fastapi breaks pydantic dependency resolution

Changing the dev extra from fastapi >= 0.110.0, <1 to fastapi==0.109.1 pulls in FastAPI’s older requirement pydantic>=2.0.3,<2.7. The project itself declares pydantic>=2.10,<3 in the main dependencies. When a contributor installs the dev group (e.g. uv sync --group dev or pip install .[dev]), the resolver cannot satisfy both constraints, so the environment fails to install. The previous range avoided this conflict by allowing a FastAPI that supports newer Pydantic versions.

Useful? React with 👍 / 👎.

@seratch seratch closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants