Skip to content

add build support for Cython versions >=3 #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add build support for Cython versions >=3 #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2786233
add support for `Cython` versions >=3
Kallinteris-Andreas Dec 5, 2023
68aa04f
Bump version for release
Kallinteris-Andreas Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mujoco_py/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import cython
import distutils
import glob
import os
Expand Down Expand Up @@ -236,7 +237,10 @@ def _build_impl(self):
"script_name": None,
"script_args": ["build_ext"]
})
dist.ext_modules = cythonize([self.extension])
if cython.__version__ < "3.0.0":
dist.ext_modules = cythonize([self.extension])
else:
dist.ext_modules = cythonize([self.extension], compiler_directives={'legacy_implicit_noexcept': True})
dist.include_dirs = []
dist.cmdclass = {'build_ext': custom_build_ext}
build = dist.get_command_obj('build')
Expand Down
2 changes: 1 addition & 1 deletion mujoco_py/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
__all__ = ['__version__', 'get_version']

version_info = (2, 1, 2, 14)
version_info = (2, 1, 2, 15)
# format:
# ('mujoco_major', 'mujoco_minor', 'mujoco_py_major', 'mujoco_py_minor')

Expand Down