Skip to content

Conversation

thompson-tomo
Copy link
Contributor

Fixes #

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

Copy link
Contributor

@kamphaus kamphaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion having a single Sourcing Attribute Values table is more readable than multiple notes
especially for several attributes like in entities/os.md.

Taking this information from structured yaml instead of note will also allow future improvements like filtering.

I also agree with what Josh said in Monday's SemConv SIG meeting that ideally it would be possible to see the note / sourcing attribute value for a given attribute in the attribute table by hovering over an icon or [1] note text or by expanding a collapsed section.


| Attribute | Implementation | Location |
| --- | --- | --- |
| [`os.build_id`](/docs/registry/attributes/os.md) | Linux | `BUILD_ID` from `/etc/os-release` or `/usr/lib/os-release` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous note listed contents of '/proc/sys/kernel/osrelease' as a third fallback location.
Was this meant to be removed as part of this PR?

@thompson-tomo
Copy link
Contributor Author

I also agree that it would be nice solution however we are constrained to functionality which is supported in markdown hence unable to do those advanced layouts currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants