Add ASP.NET Core memory pool metrics #2533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
reviewed
Jul 19, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
JamesNK
force-pushed
the
jamesnk/memorypool-metrics
branch
from
af19518 to
3b13ed9
Compare
|
All changes have been applied. Please take another look. |
lmolkova
moved this from Untriaged
to Awaiting codeowners approval
in Semantic Conventions Triage
noahfalk
approved these changes
Aug 17, 2025
|
Is there an invariant: aspnetcore.memory_pool.pooled = aspnetcore.memory_pool.allocated - aspnetcore.memory_pool.rented - aspnetcore.memory_pool.evicted |
|
No, because rented is total. Memory could be returned and rented many times. Allocated: 50 bytes Pooled does not equal -450 bytes. One interesting piece of data is how much an application has currently leased. You can calculate the currently leased memory with this: |
JamesNK
force-pushed
the
jamesnk/memorypool-metrics
branch
from
3b13ed9 to
86a6839
Compare
lmolkova
approved these changes
Aug 20, 2025
github-project-automation
bot
moved this from Awaiting codeowners approval
to Needs More Approval
in Semantic Conventions Triage
lmolkova
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
ShipraJain01
pushed a commit
to ShipraJain01/semantic-conventions
that referenced
this pull request
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2532
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]