Skip to content

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Jun 24, 2025

Closes #1257

Changes

Deprecate all existing os types and instead use the field to describe the type of the OS ie windows or Unix. The existing types should be the os.name and/or unix.kernel.name with the later handled via #2641

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@thompson-tomo thompson-tomo force-pushed the feature/#1257_AdditionalOSTypes branch from 014141a to 44f6636 Compare July 1, 2025 02:04
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as to this is not simply adding more OS types. It is changing the behavior of the attribute entirely.

The links you added to the issue description, for example from ECS https://www.elastic.co/docs/reference/ecs/ecs-os#field-os-type also have a os.type which is pretty much the same as what we have today.

@github-project-automation github-project-automation bot moved this from Untriaged to Blocked in Semantic Conventions Triage Jul 2, 2025
@thompson-tomo thompson-tomo requested a review from joaopgrassi July 2, 2025 09:35
@thompson-tomo thompson-tomo changed the title Adds more mobile os types #1257 Adds more os types #1257 Jul 5, 2025
@thompson-tomo thompson-tomo force-pushed the feature/#1257_AdditionalOSTypes branch 2 times, most recently from 61a508e to 59ff97c Compare July 8, 2025 11:08
@thompson-tomo thompson-tomo changed the title Adds more os types #1257 rework the functionality of os types #1257 Jul 9, 2025
@thompson-tomo
Copy link
Contributor Author

@joaopgrassi can you review and unblock as implementation is following what was discussed in the semconv.

@thompson-tomo thompson-tomo changed the title rework the functionality of os types #1257 Refocus of os types #1257 Jul 28, 2025
@joaopgrassi joaopgrassi dismissed their stale review August 13, 2025 14:11

Unblocking, but we still need to get the system semconv group onboard with this change.

@joaopgrassi joaopgrassi moved this from Blocked to Awaiting codeowners approval in Semantic Conventions Triage Aug 13, 2025
- id: zos
value: 'zos'
brief: "IBM z/OS"
deprecated: "Use `os.name` instead"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zos is a real unique operating system type, I don't think we should be removing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my research it is a Unix os.

brief: "Linux"
deprecated: Should use `unix` instead'
stability: development
- id: unix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sold on putting all unixes together. I think there is still value in separating linux, darwin, and bsd at least. While it's true they are all unix-likes, they are unique enough and are treated differently enough in the minds of most users to deserve their own attributes. I think moving all the *bsd attributes to os.name is good so we can keep that, but I think this should restore linux, darwin, and bsd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So looking at implementations and language api's the common functionality is being able to determine the OS type which is what is being expressed by this attribute. You can then look at the os.name &/or os.family to get that specific info, you are after.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the previous state is more useful than just a 'unix' value. It may be too specific today, but I don't think we should jump to the other extreme.

Copy link
Contributor Author

@thompson-tomo thompson-tomo Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have os.name/os.type to be more specific. And in fact this is what I was told to implement in the sem conv meeting as I had originally extended type to include alot of other common os but that was not wanted due to it becoming a never ending list. At the same time we also needing to migrate the other properties from ecs, hence the request was to focus type on the minimal items and provide the other properties.

Also this approach here would nicely complement the solution I have proposed in #66 as if type is Unix, then you can also provide details of the Unix.kernel which could be Linux, Darwin etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To further support the simplification proposed here #2641 has now been created to express the kernel type ie linux, Darwin.

That pr provides another way to maintain the same granularity while introducing consistent attribute usage and further migration of ecs.

brief: "Linux"
deprecated: Should use `unix` instead'
stability: development
- id: unix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the previous state is more useful than just a 'unix' value. It may be too specific today, but I don't think we should jump to the other extreme.

@thompson-tomo thompson-tomo force-pushed the feature/#1257_AdditionalOSTypes branch 3 times, most recently from de5172f to 71dc443 Compare August 15, 2025 03:34
@thompson-tomo thompson-tomo mentioned this pull request Aug 19, 2025
3 tasks
@thompson-tomo thompson-tomo force-pushed the feature/#1257_AdditionalOSTypes branch from 71dc443 to bdb46dc Compare August 19, 2025 03:49
@mx-psi mx-psi mentioned this pull request Aug 27, 2025
3 tasks
@thompson-tomo thompson-tomo force-pushed the feature/#1257_AdditionalOSTypes branch from 2ccdf52 to cf0a252 Compare August 29, 2025 02:35
@thompson-tomo thompson-tomo force-pushed the feature/#1257_AdditionalOSTypes branch from 169e5b6 to 8023a56 Compare September 30, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Awaiting codeowners approval
Development

Successfully merging this pull request may close these issues.

refocus os.type
5 participants