Skip to content

Conversation

bantonsson
Copy link
Contributor

Changes

Switches the bench profile to line-tables-only, the criterion::blackbox to std::hint::blackbox and makes the profiling of benchmarks optional behind a feature flag.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@bantonsson bantonsson requested a review from a team as a code owner September 5, 2025 09:18
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.7%. Comparing base (61f86c7) to head (4ae1c50).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3150   +/-   ##
=====================================
  Coverage   80.7%   80.7%           
=====================================
  Files        126     126           
  Lines      22331   22331           
=====================================
  Hits       18023   18023           
  Misses      4308    4308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Cargo.toml Outdated
Comment on lines 15 to 16
[profile.bench]
# https://doc.rust-lang.org/cargo/reference/profiles.html#bench
# https://nnethercote.github.io/perf-book/profiling.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[profile.bench]
# https://doc.rust-lang.org/cargo/reference/profiles.html#bench
# https://nnethercote.github.io/perf-book/profiling.html
[profile.bench]
# https://doc.rust-lang.org/cargo/reference/profiles.html#debug

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks.

@bantonsson bantonsson force-pushed the ban/make-bench-profiling-optional branch from fed8313 to 4ae1c50 Compare October 7, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants