refactor: differentiate between Wrapf and Newf #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelewski
reviewed
Sep 29, 2025
|
|
||
| ## Error Handling | ||
|
|
||
| We use the `ex` package to handle errors as we want to include the stack trace |
There was a problem hiding this comment.
Should not be this file updated instead of removing?
There was a problem hiding this comment.
The idea is to focus our efforts on maintaining the documentation that lives closer to the code, instead of dealing with the overhead of keeping two redundant files in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the error handling package with several key changes:
Wrapf), which add a stack trace to an existing error, and error creation APIs (likeNewf), which create a new error from scratch with a stack trace. This makes their intended use clear and prevents misuse.