Skip to content

Conversation

WeihanLi
Copy link
Contributor

This PR

  • feat: update FeatureLifecycleStateOptions.StopState default to Stopped
  • refactor: remove the default options setup since it's same as default value, no need to configure

Related Issues

Fixes #410

remove default config since it's same as the default value for the option

Signed-off-by: Weihan Li <[email protected]>
@WeihanLi WeihanLi marked this pull request as ready for review March 31, 2025 13:55
@WeihanLi WeihanLi requested a review from a team as a code owner March 31, 2025 13:55
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (4043d3d) to head (fd25157).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          39       39           
  Lines        1603     1603           
  Branches      171      171           
=======================================
  Hits         1374     1374           
  Misses        191      191           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your contribution 👍

@beeme1mr beeme1mr added this pull request to the merge queue Apr 1, 2025
Merged via the queue into open-feature:main with commit 6c23f21 Apr 1, 2025
15 checks passed
@WeihanLi WeihanLi deleted the patch-1 branch April 1, 2025 10:31
github-merge-queue bot pushed a commit that referenced this pull request Apr 14, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.4.0](v2.3.2...v2.4.0)
(2025-04-14)


### 🐛 Bug Fixes

* Refactor error handling and improve documentation
([#417](#417))
([b0b168f](b0b168f))


### ✨ New Features

* update FeatureLifecycleStateOptions.StopState default to Stopped
([#414](#414))
([6c23f21](6c23f21))


### 🧹 Chore

* **deps:** update github/codeql-action digest to 45775bd
([#419](#419))
([2bed467](2bed467))
* restrict publish to environment
([#431](#431))
([0c222cb](0c222cb))


### 📚 Documentation

* Update contributing guidelines
([#413](#413))
([84ea288](84ea288))


### 🔄 Refactoring

* simplify the InternalsVisibleTo usage
([#408](#408))
([4043d3d](4043d3d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
WeihanLi pushed a commit to WeihanLi/openfeature-dotnet-sdk that referenced this pull request May 14, 2025
🤖 I have created a release *beep* *boop*
---

##
[2.4.0](open-feature/dotnet-sdk@v2.3.2...v2.4.0)
(2025-04-14)

### 🐛 Bug Fixes

* Refactor error handling and improve documentation
([open-feature#417](open-feature#417))
([b0b168f](open-feature@b0b168f))

### ✨ New Features

* update FeatureLifecycleStateOptions.StopState default to Stopped
([open-feature#414](open-feature#414))
([6c23f21](open-feature@6c23f21))

### 🧹 Chore

* **deps:** update github/codeql-action digest to 45775bd
([open-feature#419](open-feature#419))
([2bed467](open-feature@2bed467))
* restrict publish to environment
([open-feature#431](open-feature#431))
([0c222cb](open-feature@0c222cb))

### 📚 Documentation

* Update contributing guidelines
([open-feature#413](open-feature#413))
([84ea288](open-feature@84ea288))

### 🔄 Refactoring

* simplify the InternalsVisibleTo usage
([open-feature#408](open-feature#408))
([4043d3d](open-feature@4043d3d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureLifecycleStateOptions StopState default value proposal
3 participants