refactor: simplify the InternalsVisibleTo usage #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 39 39
Lines 1603 1603
Branches 171 171
=======================================
Hits 1374 1374
Misses 191 191
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
beeme1mr
approved these changes
Mar 27, 2025
|
Hello @WeihanLi! Thanks for contributing to our repo. The changes look good, but you must sign off on your commits. Could you please follow these instructions (https://github.com/open-feature/dotnet-sdk/pull/408/checks?check_run_id=39505764635)? |
Signed-off-by: Weihan Li <[email protected]>
Signed-off-by: Weihan Li <[email protected]>
|
@askpt thanks, commits updated |
askpt
approved these changes
Mar 28, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
🤖 I have created a release *beep* *boop* --- ## [2.4.0](v2.3.2...v2.4.0) (2025-04-14) ### 🐛 Bug Fixes * Refactor error handling and improve documentation ([#417](#417)) ([b0b168f](b0b168f)) ### ✨ New Features * update FeatureLifecycleStateOptions.StopState default to Stopped ([#414](#414)) ([6c23f21](6c23f21)) ### 🧹 Chore * **deps:** update github/codeql-action digest to 45775bd ([#419](#419)) ([2bed467](2bed467)) * restrict publish to environment ([#431](#431)) ([0c222cb](0c222cb)) ### 📚 Documentation * Update contributing guidelines ([#413](#413)) ([84ea288](84ea288)) ### 🔄 Refactoring * simplify the InternalsVisibleTo usage ([#408](#408)) ([4043d3d](4043d3d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
WeihanLi
pushed a commit
to WeihanLi/openfeature-dotnet-sdk
that referenced
this pull request
May 14, 2025
🤖 I have created a release *beep* *boop* --- ## [2.4.0](open-feature/dotnet-sdk@v2.3.2...v2.4.0) (2025-04-14) ### 🐛 Bug Fixes * Refactor error handling and improve documentation ([open-feature#417](open-feature#417)) ([b0b168f](open-feature@b0b168f)) ### ✨ New Features * update FeatureLifecycleStateOptions.StopState default to Stopped ([open-feature#414](open-feature#414)) ([6c23f21](open-feature@6c23f21)) ### 🧹 Chore * **deps:** update github/codeql-action digest to 45775bd ([open-feature#419](open-feature#419)) ([2bed467](open-feature@2bed467)) * restrict publish to environment ([open-feature#431](open-feature#431)) ([0c222cb](open-feature@0c222cb)) ### 📚 Documentation * Update contributing guidelines ([open-feature#413](open-feature#413)) ([84ea288](open-feature@84ea288)) ### 🔄 Refactoring * simplify the InternalsVisibleTo usage ([open-feature#408](open-feature#408)) ([4043d3d](open-feature@4043d3d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Weihan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
simplify and unify the InternalsVisibleTo usage