Skip to content

🔧 refactor(data): Polish BMAD dataset #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: feature/dataset/bmad
Choose a base branch
from
Open

🔧 refactor(data): Polish BMAD dataset #2981

wants to merge 2 commits into from

Conversation

ashwinvaidya17
Copy link
Contributor

📝 Description

  • 🧪 Add tests
  • 📋 Fix documentation
  • 🛠️ Minor fixes

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

@ashwinvaidya17
🧹 Polish dataset
8bd5e77 
🧪 Add tests
📋 Fix documentation
🛠️  Minor fixes

Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17 ashwinvaidya17 changed the title 🔧 refactor(data) Polish BMAD dataset 🔧 refactor(data): Polish BMAD dataset Sep 30, 2025
rajeshgangireddy
rajeshgangireddy reviewed Oct 1, 2025
View reviewed changes
tests/unit/data/datamodule/image/test_bmad.py
@staticmethod
def datamodule(dataset_path: Path) -> BMAD:
"""Create and return a BMAD datamodule."""
datamodule_ = BMAD(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this download the dataset ?
(downloading and extracting 20GB could take a while)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this will download the entire dataset

@ashwinvaidya17 @rajeshgangireddy
Update src/anomalib/data/datamodules/image/bmad.py
b8f71e6 
Co-authored-by: Rajesh Gangireddy <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeshgangireddy rajeshgangireddy rajeshgangireddy left review comments

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwinvaidya17 @rajeshgangireddy