-
Notifications
You must be signed in to change notification settings - Fork 97
Improve KubeAI autoscaling support #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@poussa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves KubeAI autoscaling support by updating autoscaling configurations and providing clearer examples for node selection and model deployment. Key changes include:
- Adding commented-out example nodeSelectors to the OPEA values file.
- Updating the 70b Gaudi model configuration to scale from zero with explanatory comments.
- Adjusting the 8b Gaudi model configuration and updating the README with corrected deployment instructions.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
kubeai/opea-values.yaml | Added example nodeSelector blocks |
kubeai/models/llama-3.3-70b-instruct-gaudi.yaml | Changed autoscaling parameters and added clarifying comments |
kubeai/models/llama-3.1-8b-instruct-gaudi.yaml | Updated environment variable formatting and set maxReplicas |
kubeai/README.md | Revised documentation to reflect updated autoscaling behavior |
6b7f22a
to
0cba77f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Eero Tamminen <[email protected]>
Signed-off-by: Eero Tamminen <[email protected]>
Signed-off-by: Eero Tamminen <[email protected]>
Signed-off-by: Eero Tamminen <[email protected]>
Signed-off-by: Eero Tamminen <[email protected]>
(Review request.) Signed-off-by: Eero Tamminen <[email protected]>
@mkbhanda OK to merge? |
Signed-off-by: Eero Tamminen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eero-t, looks good to me
Description
KubeAI updates:
Issues
n/a
.Type of change
Dependencies
n/a
.Tests
Manual testing for scaling / changes.