Skip to content

Conversation

ZePan110
Copy link
Collaborator

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: ZePan110 <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 07:46
@ZePan110 ZePan110 added the WIP label Sep 25, 2025
Copy link

github-actions bot commented Sep 25, 2025

Dependency Review

The following issues were found:
  • ❌ 1 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

Vulnerabilities

one_click_deploy/requirements.txt

NameVersionVulnerabilitySeverity
urllib32.2.3urllib3 redirects are not disabled when retries are disabled on PoolManager instantiationmoderate
urllib3 does not control redirects in browsers and Node.jsmoderate

License Issues

one_click_deploy/requirements.txt

PackageVersionLicenseIssue Type
ruamel-yaml0.18.15NullUnknown License
ruamel-yaml-clib0.2.8NullUnknown License

Scanned Files

  • .github/workflows/_build_image.yml
  • .github/workflows/_get-image-list.yml
  • .github/workflows/_get-test-matrix.yml
  • .github/workflows/_helm-e2e.yml
  • .github/workflows/_run-docker-compose.yml
  • .github/workflows/_run-one-click.yml
  • .github/workflows/_trivy-scan.yml
  • .github/workflows/check-online-doc-build.yml
  • .github/workflows/dockerhub-description.yml
  • .github/workflows/manual-docker-scan.yml
  • .github/workflows/manual-freeze-tag.yml
  • .github/workflows/mix-trellix.yml
  • .github/workflows/pr-chart-e2e.yml
  • .github/workflows/pr-check-duplicated-image.yml
  • .github/workflows/pr-code-scan.yml
  • .github/workflows/pr-dependency-review.yml
  • .github/workflows/pr-dockerfile-path-and-build-yaml-scan.yml
  • .github/workflows/pr-image-size.yml
  • .github/workflows/pr-link-path-scan.yml
  • .github/workflows/push-images-path-detection.yml
  • .github/workflows/push-infra-issue-creation.yml
  • .github/workflows/scorecard.yml
  • .github/workflows/weekly-one-click-test.yml
  • .github/workflows/weekly-update-images.yml
  • one_click_deploy/requirements.txt

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to be a test update that modifies testing scripts and CI workflow configurations. The changes focus on updating dependency versions and improving test execution reliability.

  • Updates Playwright version from unspecified to 1.44.0 with explicit version pinning
  • Adds SHA256 hash pinning to GitHub Actions checkout action for enhanced security
  • Removes redundant npm install command in favor of npm ci for more reliable builds

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ChatQnA/tests/test_compose_openeuler_on_xeon.sh Updates Playwright commands to use specific version 1.44.0 and removes redundant npm install
.github/workflows/weekly-one-click-test.yml Adds SHA256 hash to checkout action for security pinning

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v4@sha256:1e31de5234b9f8995739874a8ce0492dc87873e2
Copy link
Preview

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax for pinning GitHub Actions with SHA256 is incorrect. The correct format should be actions/checkout@sha256:1e31de5234b9f8995739874a8ce0492dc87873e2 (without the @v4 part). The current syntax will likely cause the workflow to fail.

Suggested change
uses: actions/checkout@v4@sha256:1e31de5234b9f8995739874a8ce0492dc87873e2
uses: actions/checkout@sha256:1e31de5234b9f8995739874a8ce0492dc87873e2

Copilot uses AI. Check for mistakes.

Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
c
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant