-
Notifications
You must be signed in to change notification settings - Fork 317
test #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test #2289
Conversation
Signed-off-by: ZePan110 <[email protected]>
Dependency ReviewThe following issues were found:
Vulnerabilitiesone_click_deploy/requirements.txt
License Issuesone_click_deploy/requirements.txt
Scanned Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR appears to be a test update that modifies testing scripts and CI workflow configurations. The changes focus on updating dependency versions and improving test execution reliability.
- Updates Playwright version from unspecified to 1.44.0 with explicit version pinning
- Adds SHA256 hash pinning to GitHub Actions checkout action for enhanced security
- Removes redundant npm install command in favor of npm ci for more reliable builds
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
ChatQnA/tests/test_compose_openeuler_on_xeon.sh | Updates Playwright commands to use specific version 1.44.0 and removes redundant npm install |
.github/workflows/weekly-one-click-test.yml | Adds SHA256 hash to checkout action for security pinning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
uses: actions/checkout@v4@sha256:1e31de5234b9f8995739874a8ce0492dc87873e2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax for pinning GitHub Actions with SHA256 is incorrect. The correct format should be actions/checkout@sha256:1e31de5234b9f8995739874a8ce0492dc87873e2
(without the @v4 part). The current syntax will likely cause the workflow to fail.
uses: actions/checkout@v4@sha256:1e31de5234b9f8995739874a8ce0492dc87873e2 | |
uses: actions/checkout@sha256:1e31de5234b9f8995739874a8ce0492dc87873e2 |
Copilot uses AI. Check for mistakes.
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
…mples into ze-fix/sec Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
4011ca0
to
b39ab88
Compare
Signed-off-by: ZePan110 <[email protected]>
b39ab88
to
5bd4674
Compare
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.