Refine UI test scripts. #2282
Merged
Refine UI test scripts. #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
ZePan110
requested review from
lvliang-intel,
Spycsh,
WenjiaoYue,
BaoHuiling,
yao531441,
letonghan,
jaswanth8888,
hteeyeoh,
rbrugaro,
ashahba,
ftian1,
chensuyue,
lkk12014402 and
minmin-intel
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR refines UI test scripts across multiple components by consolidating frontend testing logic and removing duplicate validation functions. The main purpose is to reduce code duplication by removing redundant validate_frontend functions from compose test scripts while preserving them in dedicated UI test scripts.
- Adds new dedicated UI test scripts for multiple components (VisualQnA, VideoQnA, Translation, SearchQnA, ProductivitySuite, HybridRAG, GraphRAG, DBQnA, CodeTrans, CodeGen)
- Removes duplicate
validate_frontendfunctions from existing compose test scripts - Makes minor configuration adjustments to Docker compose files and ESLint configuration
Reviewed Changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Multiple **/tests/test_ui_on_*.sh | New dedicated UI test scripts for various components |
| Multiple **/tests/test_compose_*.sh | Removed duplicate validate_frontend functions and associated calls |
| ChatQnA/docker_compose/intel/hpu/gaudi/*.yaml | Updated Docker image references to use opea registry |
| ChatQnA/ui/svelte/.eslintrc.cjs | Added comment line to ESLint configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ZePan110
force-pushed
the
ze-opt/ui2
branch
from
12c8c99 to
e1d8193
Compare
Signed-off-by: ZePan110 <[email protected]>
|
SearchQnA ui test failure will fix by another PR. |
|
SearchQnA known issue: #2292 |
chensuyue
approved these changes
Sep 26, 2025
joshuayao
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refine UI test scripts
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.