Skip to content

Support for AMD EPYC via Docker Containers #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 30, 2025
Merged

Support for AMD EPYC via Docker Containers #2083

merged 15 commits into from
Jul 30, 2025

Conversation

Jereshea
Copy link
Collaborator

Description

This PR introduces support for AMD EPYC servers by providing Docker container configurations and updates.

Key Changes

1. New Docker Configurations:

  • Added docker-compose.yaml files specific for AMD EPYC.

2. Environment Updates:

  • Introduced set_env.sh scripts tailored for AMD EPYC deployment.
  • Adjustments to environment variables for seamless integration.

3. Documentation Updates:

  • Updated the README to include deployment instructions for AMD EPYC servers.
  • Added guidance for setting up the environment and troubleshooting on AMD servers.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@Jereshea Jereshea force-pushed the AMD-EPYC branch 2 times, most recently from a806efb to 94bde59 Compare June 20, 2025 09:56
@chensuyue
Copy link
Collaborator

Thanks for the contribution, you need to provide an EPYC instance add into CI for test. And also need scripts like this one for test, https://github.com/opea-project/GenAIExamples/blob/main/AudioQnA/tests/test_compose_on_rocm.sh, which should be named as test_compose_on_epyc.sh.

@Jereshea
Copy link
Collaborator Author

Jereshea commented Jul 8, 2025

Thanks for the contribution, you need to provide an EPYC instance add into CI for test. And also need scripts like this one for test, https://github.com/opea-project/GenAIExamples/blob/main/AudioQnA/tests/test_compose_on_rocm.sh, which should be named as test_compose_on_epyc.sh.

Thank You @chensuyue for the feedback. I'll update the script accordingly and prepare the test_compose_on_epyc.sh as suggested. I will also look into adding an EPYC instance into CI for testing.

@chensuyue
Copy link
Collaborator

Thanks for the contribution, you need to provide an EPYC instance add into CI for test. And also need scripts like this one for test, https://github.com/opea-project/GenAIExamples/blob/main/AudioQnA/tests/test_compose_on_rocm.sh, which should be named as test_compose_on_epyc.sh.

Thank You @chensuyue for the feedback. I'll update the script accordingly and prepare the test_compose_on_epyc.sh as suggested. I will also look into adding an EPYC instance into CI for testing.

Welcome, let me know when you have the test machine, I will help to add it into opea CI.

@Jereshea Jereshea force-pushed the AMD-EPYC branch 2 times, most recently from eb647fe to d4f3d78 Compare July 15, 2025 14:40
chensuyue
chensuyue reviewed Jul 18, 2025
View reviewed changes
@Jereshea Jereshea force-pushed the AMD-EPYC branch 5 times, most recently from a5f459a to f00ca8a Compare July 23, 2025 06:11
@chensuyue
Copy link
Collaborator

Please fix the shell scripts issue, https://github.com/opea-project/GenAIExamples/actions/runs/16463309172/job/46534937488?pr=2083

@Jereshea Jereshea force-pushed the AMD-EPYC branch 4 times, most recently from 417cb78 to 6897604 Compare July 25, 2025 12:26
chensuyue
chensuyue reviewed Jul 29, 2025
View reviewed changes
chensuyue
chensuyue reviewed Jul 29, 2025
View reviewed changes
chensuyue
chensuyue reviewed Jul 29, 2025
View reviewed changes
@chensuyue
Copy link
Collaborator

Please use HF_TOKEN instead of HUGGINGFACEHUB_API_TOKEN, for all the use cases.

Jereshea and others added 12 commits July 29, 2025 05:26
@Jereshea
Support of Docker Containers for AMD EPYC
b177cef 
Signed-off-by: Jereshea J M <[email protected]>
@Jereshea
Updated the code base with prettier-vscode
1e79d0b 
Signed-off-by: Jereshea J M <[email protected]>
@Jereshea
Added test scripts for AMD EPYC examples
bb67b39 
Signed-off-by: Jereshea J M <[email protected]>
@pre-commit-ci @Jereshea
[pre-commit.ci] auto fixes from pre-commit.com hooks
3cefc6c 
for more information, see https://pre-commit.ci
@Jereshea
Renamed test_compose_on_epyc_tgi.sh to test_compose_tgi_on_epyc.sh
129f527 
Signed-off-by: Jereshea J M <[email protected]>
@Jereshea
Bug fix when activating conda environment
a340ae0 
Signed-off-by: Jereshea J M <[email protected]>
@Jereshea
Fix for Code Scan issue
284fcea 
Signed-off-by: Jereshea J M <[email protected]>
@Jereshea
VLLM docker error fix
200ebca 
Signed-off-by: Jereshea J M <[email protected]>
@Jereshea
Fix for permission issue in CI Run
f174ab0 
Signed-off-by: Jereshea J M <[email protected]>
@pre-commit-ci @Jereshea
[pre-commit.ci] auto fixes from pre-commit.com hooks
17b86ac 
for more information, see https://pre-commit.ci
@Jereshea
Removing the usecase with CI error
b3a219a 
Signed-off-by: Jereshea J M <[email protected]>
@Jereshea
Refactor: Use HF_TOKEN instead of HUGGINGFACEHUB_API_TOKEN and update…
c77d280 
… script names

Signed-off-by: Jereshea J M <[email protected]>
@Jereshea Jereshea force-pushed the AMD-EPYC branch 2 times, most recently from 4c199f6 to 75a3050 Compare July 29, 2025 06:02
@Jereshea
Fix for ShellCheck
b16eca2 
Signed-off-by: Jereshea J M <[email protected]>
@Jereshea Jereshea force-pushed the AMD-EPYC branch 3 times, most recently from cb7953e to 206eda8 Compare July 29, 2025 06:16
@Jereshea
Retrigger CI run
77ac09f 
Signed-off-by: Jereshea J M <[email protected]>
@ftian1 ftian1 merged commit 427293c into opea-project:main Jul 30, 2025
72 of 74 checks passed
alexsin368 pushed a commit to alexsin368/GenAIExamples that referenced this pull request Aug 13, 2025
@Jereshea @pre-commit-ci @alexsin368
Support for AMD EPYC via Docker Containers (opea-project#2083)
c94127a 
Signed-off-by: Jereshea J M <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: alexsin368 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftian1 ftian1 ftian1 approved these changes

@chensuyue chensuyue chensuyue approved these changes

@lvliang-intel lvliang-intel Awaiting requested review from lvliang-intel lvliang-intel is a code owner

@Spycsh Spycsh Awaiting requested review from Spycsh Spycsh is a code owner

@WenjiaoYue WenjiaoYue Awaiting requested review from WenjiaoYue WenjiaoYue is a code owner

@yao531441 yao531441 Awaiting requested review from yao531441 yao531441 is a code owner

@XinyuYe-Intel XinyuYe-Intel Awaiting requested review from XinyuYe-Intel XinyuYe-Intel is a code owner

@letonghan letonghan Awaiting requested review from letonghan letonghan is a code owner

@jaswanth8888 jaswanth8888 Awaiting requested review from jaswanth8888 jaswanth8888 is a code owner

@hteeyeoh hteeyeoh Awaiting requested review from hteeyeoh hteeyeoh is a code owner

@mhbuehler mhbuehler Awaiting requested review from mhbuehler mhbuehler is a code owner

@tileintel tileintel Awaiting requested review from tileintel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jereshea @chensuyue @ftian1