Stick/unstick fp32 data alloc at 4k pages #3250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
tungld
approved these changes
Aug 1, 2025
| assert(allocOfXOp && "unstick output should always be allocated"); | ||
| auto alignmentAttr = allocOfXOp.getAlignment(); | ||
| int64_t intAlign = alignmentAttr ? alignmentAttr.value() : 1; | ||
| if (intAlign >= gAlignment) { |
There was a problem hiding this comment.
Should it be (intAlign != 0 && intAlign % gAlignment == 0)?
There was a problem hiding this comment.
Ok, that would protect us if for some reason we were to align buffers to multiple of 4k. But then what happens if we want an align to 7k... should we bump it to 8k?
That is what I implemented, next 4k page given current alignment of alloc.
|
@jenkins-droid test this please |
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cedric mentioned that 4k page alignment for the fp32 data is beneficial for performance.
This PR add 4k alignment for data used by
zlow.stickwhen not implemented on CPU. For unstick, it was already the case in all but one case (which is added by this PR).Option is default on for z17, off for z16 (as stick is always done in software).