The last CTL patch :) #1524
Open
The last CTL patch :) #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
force-pushed
the
ctl_split
branch
11 times, most recently
from
629b379 to
2706166
Compare
Split between initialize and post-initialize function is necessary for properly handling CTL defaults.
lukaszstolarczuk
requested changes
Sep 19, 2025
defaults changes global state, so using forks will isolate tests
|
|
||
| UMF's experimental CTL API is showcased in the [CTL example](examples/ctl/ctl.c), | ||
| which explores provider and pool statistics, and in the [custom CTL example](examples/ctl/custom_ctl.c), which wires CTL support into a bespoke memory | ||
| provider. These examples rely on experimental headers whose interfaces may |
There was a problem hiding this comment.
whose refer to people -> perhaps: ... experimental headers which may change ...
| sizeof(alloc_count), name, i); | ||
| } | ||
|
|
||
| Ensure that the types of wildcard arguments match the expected node types. |
There was a problem hiding this comment.
otherwise what? you get an error, a crash, ...?
| sizeof(capacity)); | ||
|
|
||
| Every subsequently created disjoint pool will use ``16`` as its starting | ||
| capacity overriding it's creation parameters. Defaults are keyed by the |
|
|
||
| UMF_CONF="umf.logger.output=stdout;umf.logger.level=0" | ||
|
|
||
| CTL options available through environment variables are limited—you can only |
There was a problem hiding this comment.
limited—you misspell
| Within each subsystem the path continues with an addressing scheme followed by | ||
| the module or leaf of interest. | ||
|
|
||
| Reading this reference |
There was a problem hiding this comment.
consider renaming this section to Reading below sections or dunno, something else ;d
| :type:`umf_memory_provider_handle_t` argument to reach a specific provider. | ||
| Providers can also be addressed by name through ``umf.provider.by_name.{provider}``; | ||
| append ``.{index}`` to address specific provider when multiple providers share the same label. | ||
| Defaults for future providers reside under ``umf.provider.default.{provider}`` and track the |
There was a problem hiding this comment.
not sure what you meant by ... and track the name ...
| =========== | ||
|
|
||
| A ``{}`` in the path acts as a wildcard and is replaced with successive | ||
| arguments of ``umfCtlGet``, ``umfCtlSet`` or ``umfCtlExec``. Wildcards can |
There was a problem hiding this comment.
set and get are explained, but umfCtlExec wasn't
| target_include_directories(${ EXAMPLE_NAME} PRIVATE ${ LIBUMF_INCLUDE_DIRS}) | ||
| target_link_directories( | ||
| ${ | ||
| EXAMPLE_NAME} |
There was a problem hiding this comment.
that's a weird formatting - can you make it like ${EXAMPLE_NAME}...?
// fix below, as well pls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.