Standardize module naming in requirements.txt files #2602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pip normalizes all package names which shouldn't have any errors when installing packages e.g., tensorflow_hub and tensorflow-hub is treated as the same and will install tensorflow-hub, however if users install using 'conda install' it will encounter module not found errors as conda does not normalize module package names. This change is also to standardize module names in requirements.txt files to be the same as the names in pip repositories Signed-off-by: Lim, Lukaz Wei Hwang <[email protected]>
|
This PR is submitted under oneAPI_CS_Team4 for hackathon |
|
@lukazlim thanks for the great PR. It's a subtle but good quality of life improvement. @jimmytwei the PR LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Pip normalizes all package names which shouldn't have any errors when installing packages e.g., tensorflow_hub and tensorflow-hub is treated as the same and will install tensorflow-hub, however if users install using 'conda install' it will encounter module not found errors as conda does not normalize module package names. This change is also to standardize those module names to be the same as the names in package repositories.
Not related to any issue tickets.
External Dependencies
No additional external dependencies.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration