Fix jsons #2140
Merged
Fix jsons #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whitepau Do you need approval and merge? |
|
Yes please
…________________________________
From: Jimmy Wei ***@***.***>
Sent: Thursday, January 18, 2024 10:37:39 PM
To: oneapi-src/oneAPI-samples ***@***.***>
Cc: White, Paul ***@***.***>; Mention ***@***.***>
Subject: Re: [oneapi-src/oneAPI-samples] Fix jsons (PR #2140)
@whitepau<https://github.com/whitepau> Do you need approval and merge?
—
Reply to this email directly, view it on GitHub<#2140 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUQVN7PWJV75X4HFJTJMIZ3YPGI2HAVCNFSM6AAAAABCABL2ZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGI2DCMRSGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
I noticed that some of the FPGA code samples were not correctly categorized in the sample browser, i have updated the appropriate sample.json files to fix this.
I've also promoted one of our code samples to 'Tier 1'.
Since this is only a documentation change, no testing was performed.
Fixes Issue#
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Since this is only a documentation change, no testing was performed.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration