Skip to content

Add tests for Loader Driver interaction conformance for Sysman VF Management API's #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2025
Merged

Add tests for Loader Driver interaction conformance for Sysman VF Management API's #360

merged 4 commits into from
Jul 30, 2025

Conversation

vishnu-khanth
Copy link
Contributor

Related-To: NEO-15334

@vishnu-khanth vishnu-khanth marked this pull request as ready for review July 18, 2025 05:05
@vishnu-khanth vishnu-khanth force-pushed the ldr_driver_interaction branch from e2cdb8e to ec50c9c Compare July 21, 2025 12:34
nrspruit
nrspruit previously approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vishnu-khanth
Copy link
Contributor Author

vishnu-khanth commented Jul 21, 2025 •
edited
Loading

Now with this null driver update, will add tests for all L0 API's (Core, Sysman & Tools) in a separate PR

@vishnu-khanth
Copy link
Contributor Author

vishnu-khanth commented Jul 21, 2025 •
edited
Loading

Just did a minor refactor. Thanks!

@vishnu-khanth vishnu-khanth marked this pull request as draft July 22, 2025 06:38
@vishnu-khanth
Copy link
Contributor Author

vishnu-khanth commented Jul 24, 2025 •
edited
Loading

Right now keeping it in draft bcos exploring if any other better method exists which can be extensible for other validation like structs in/out.
E.g: Instead of env, writing to a file etc...

Will finalize before merging this & going ahead for updating all API's

@vishnu-khanth vishnu-khanth marked this pull request as ready for review July 30, 2025 13:50
@vishnu-khanth
Add tests for Loader Driver interaction conformance for Sysman VF Man…
f20421e 
…agement API's

Related-To: NEO-15334

Signed-off-by: Vishnu Khanth <[email protected]>
@vishnu-khanth
Add tests for Loader Driver interaction conformance for Sysman VF Man…
1868495 
…agement API's

Related-To: NEO-15334

Signed-off-by: Vishnu Khanth <[email protected]>
@vishnu-khanth
Add tests for Loader Driver interaction conformance for Sysman VF Man…
9169323 
…agement API's

Related-To: NEO-15334

Signed-off-by: Vishnu Khanth <[email protected]>
@vishnu-khanth
Add tests for Loader Driver interaction conformance for Sysman VF Man…
67d1197 
…agement API's

Related-To: NEO-15334

Signed-off-by: Vishnu Khanth <[email protected]>
@vishnu-khanth vishnu-khanth force-pushed the ldr_driver_interaction branch from 35de06d to 67d1197 Compare July 30, 2025 13:51
@vishnu-khanth
Copy link
Contributor Author

Right now keeping it in draft bcos exploring if any other better method exists which can be extensible for other validation like structs in/out. E.g: Instead of env, writing to a file etc...

Will finalize before merging this & going ahead for updating all API's

Finalized the approach. This approach itself looks good to me

@vishnu-khanth
Copy link
Contributor Author

Rebased the PR to get the latest changes.
@nrspruit PR is ready to merge once the checks are passed. Thanks!

@nrspruit nrspruit merged commit e121961 into oneapi-src:master Jul 30, 2025
50 checks passed
@vishnu-khanth vishnu-khanth deleted the ldr_driver_interaction branch July 30, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrspruit nrspruit nrspruit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishnu-khanth @nrspruit