Support for Multiple DNNs per Device Group with a Single UPF #389

anaswarac-dac · 2025-07-16T12:09:22Z

📌 Description:
This PR introduces support for associating multiple DNNs to a single device group in the 5G Core, enabling flexible and scalable configurations in deployments with a single UPF.

✅ Key Highlights:
Introduced configuration support for multiple DNNs per IMSI range in the sdcore-5g-values.yml file.

Each DNN can have its own:

IP pool

MTU

DNS

UE QoS profile (including MBR uplink/downlink and traffic class)

Validated end-to-end traffic flow for both ims and internet DNNs over the same UPF.

📂 Configuration Changes (in sdcore-5g-values.yml):

✅ device-groups Section:

ip-domains list now includes multiple DNNs (ims, internet) under a single group (gnbsim-user-group1).
ip-domain-expanded changed to ip-domains
Each DNN is mapped to a different ue-ip-pool and ue-dnn-qos.
device-groups:
- name: "gnbsim-user-group1"
imsis:
- "208930100007487"
- "208930100007488"
- "208930100007489"
- "208930100007490"
- "208930100007491"
- "208930100007492"
- "208930100007493"
- "208930100007494"
- "208930100007495"
- "208930100007496"
ip-domain-name: "pool1"
ip-domains:
- dnn: ims
dns-primary: "8.8.8.8"
mtu: 1400
ue-ip-pool: "172.252.0.0/16"
ue-dnn-qos:
dnn-mbr-downlink: 2400
dnn-mbr-uplink: 1200
bitrate-unit: Kbps
traffic-class:
name: "platinum"
qci: 5
arp: 1
pdb: 100
pelr: 6
- dnn: internet
dns-primary: "10.176.0.11"
mtu: 1460
ue-ip-pool: {{ core.upf.default_upf.ue_ip_pool }}
ue-dnn-qos:
dnn-mbr-downlink: 1000
dnn-mbr-uplink: 1000
bitrate-unit: Mbps
traffic-class:
name: "platinum"
qci: 9
arp: 6
pdb: 300
pelr: 6
site-info: "enterprise"

✅ Userplane Section:
Defined dnn_list with individual DNNs and their respective ue_ip_pool.
cpiface:
dnn_list:
- dnn: "ims"
ue_ip_pool: "172.252.0.0/16"
- dnn: "internet"
ue_ip_pool: "172.250.0.0/16" # Must match slice DNN
hostname: "upf"
enable_ue_ip_alloc: false

Signed-off-by: anaswara <[email protected]>

gab-arrobo · 2025-07-16T17:25:52Z

@anaswarac-dac,
Similar comment/note as in your UDR PR, we (@gatici, @patriciareinoso, @dariofaccin, @ghislainbourgeois) are in the process of replacing the GRPC communication for the SBI (across the NFs). Some NFs such as udm, udr, nssf, nrf and ausf are already using the REST-based communication instead of the GRPC-based communication. Migration is still pending for the pcf, amf and smf. Currently, the webconsole runs 2 servers (GRPC-based and REST-based) because we are still in the migration process and as soon as the remaining NFs get migrated to REST-based communication, the GRPC server will be removed from the webconsole.

@gatici, @patriciareinoso, @dariofaccin, is it possible that we complete the migration to REST-based such that @anaswarac-dac can enable the multi-DNN support per device group feature/capability based on the latest codebase?

@anaswarac-dac, the REST-based communication relies on the openapi repo (https://github.com/omec-project/openapi/tree/main/nfConfigApi)

patriciareinoso · 2025-07-17T08:23:51Z

@anaswarac-dac, Similar comment/note as in your UDR PR, we (@gatici, @patriciareinoso, @dariofaccin, @ghislainbourgeois) are in the process of replacing the GRPC communication for the SBI (across the NFs). Some NFs such as udm, udr, nssf, nrf and ausf are already using the REST-based communication instead of the GRPC-based communication. Migration is still pending for the pcf, amf and smf. Currently, the webconsole runs 2 servers (GRPC-based and REST-based) because we are still in the migration process and as soon as the remaining NFs get migrated to REST-based communication, the GRPC server will be removed from the webconsole.

@gatici, @patriciareinoso, @dariofaccin, is it possible that we complete the migration to REST-based such that @anaswarac-dac can enable the multi-DNN support per device group feature/capability based on the latest codebase?

@anaswarac-dac, the REST-based communication relies on the openapi repo (https://github.com/omec-project/openapi/tree/main/nfConfigApi)

Hi @gab-arrobo @anaswarac-dac , we are actively working on the migration. What's left:

Webconsole: implementation of 1 endpoint. Good progress. Taken care by @Gmerold
SMF: in progress. Taken care by @gatici
AMF: just started. Taken care by @dariofaccin
PCF: not started yet

We are not modifying the UPF so that could be a good starting point for @anaswarac-dac
The webconsole and SMF are expected to be finished soon.

patriciareinoso

Hi @anaswarac-dac ,

I have questions regarding the direction of this implementation:

1.1. In which configuration or to what purpose would we need to have multiple DNNs with different IP pools / QoS for a device group? It means that a subscriber will now be associated to multiple DNNs/ QoS.
When we say "allow the UPF to support multiple DNNs" I would have expected it to be for a configuration like:

Network slice A with device group using DNN1, network slice B with device group using DNN2 , both network slices served by the same UPF
or maybe, 1 network slice, with 2 device groups, each one using a different DNN

1.2. How will the UE request for multiple DNNs?
1.3. Do you have a specification/document that we can refer to to better understand the implementation of this feature?

Some comments around the code implementation:

2.1. Please run the following command to update the swagger documentation

swag init -g backend/webui_service/swagger_ui_service.go --outputTypes go

2.2. I have some concerns regarding the QoS aggregation. If we want to keep the information of multiple DNNs, why do we need to aggregate the values?

2.3 How are we going to deal with DB migration?

patriciareinoso · 2025-07-17T10:48:17Z

configmodels/model_device_groups.go

 	IpDomainName string `json:"ip-domain-name,omitempty"`

-	IpDomainExpanded DeviceGroupsIpDomainExpanded `json:"ip-domain-expanded,omitempty"`
+	IpDomainExpanded []DeviceGroupsIpDomainExpanded `json:"ip-domains,omitempty"`


Suggested change

IpDomainExpanded []DeviceGroupsIpDomainExpanded `json:"ip-domains,omitempty"`

IpDomains []DeviceGroupsIpDomainExpanded `json:"ip-domains,omitempty"`

patriciareinoso · 2025-07-17T10:51:13Z

configapi/device_group_helpers.go

+		logger.ConfigLog.Infof("DNN Name : %v", ipdomain.Dnn)
+		logger.ConfigLog.Infof("UE Pool  : %v", ipdomain.UeIpPool)
+		logger.ConfigLog.Infof("DNS Primary : %v", ipdomain.DnsPrimary)
+		logger.ConfigLog.Infof("DNS Secondary : %v", ipdomain.DnsSecondary)


these can stay as %s since they are strings

patriciareinoso · 2025-07-17T10:53:25Z

configapi/device_group_helpers.go

 	logger.ConfigLog.Infof("received device group: %s", groupName)

-	ipdomain := &requestDeviceGroup.IpDomainExpanded
+	ipdomains := &requestDeviceGroup.IpDomainExpanded


Suggested change

ipdomains := &requestDeviceGroup.IpDomainExpanded

ipdomains := requestDeviceGroup.IpDomainExpanded

patriciareinoso · 2025-07-17T10:53:45Z

configapi/device_group_helpers.go

-		ipdomain.UeDnnQos.DnnMbrUplink = convertToBps(ipdomain.UeDnnQos.DnnMbrUplink, ipdomain.UeDnnQos.BitrateUnit)
-		if ipdomain.UeDnnQos.DnnMbrUplink < 0 {
-			ipdomain.UeDnnQos.DnnMbrUplink = math.MaxInt64
+	for i, ipdomain := range *ipdomains {


Suggested change

for i, ipdomain := range *ipdomains {

for i, ipdomain := range ipdomains {

patriciareinoso · 2025-07-17T10:55:08Z

configmodels/model_device_groups.go

 	IpDomainName string `json:"ip-domain-name,omitempty"`

-	IpDomainExpanded DeviceGroupsIpDomainExpanded `json:"ip-domain-expanded,omitempty"`


it seems to be a mismatch on the struct now, we have 1 ip domain name but multiple ip domains

patriciareinoso · 2025-07-17T11:46:05Z

configapi/slice_helpers.go

+			for _, ipDomain := range devGroupConfig.IpDomainExpanded {
+				dnn := ipDomain.Dnn
+
+				// Ensure UeDnnQos is not nil before appending
+				if ipDomain.UeDnnQos != nil {
+					dnnMap[dnn] = append(dnnMap[dnn], *ipDomain.UeDnnQos) // Directly append the UeDnnQos
+				}


this should be done outside of the devGroupConfig.Imsis loop

patriciareinoso · 2025-07-17T11:52:21Z

configapi/device_group_helpers.go

 	return nil
 }

 func deviceGroupPostHelper(requestDeviceGroup configmodels.DeviceGroups, msgOp int, groupName string) (int, error) {


we need to add validation in this function to make sure that the DNN is different than empty string.
Also, should each IP domain should use a different DNN name?
if validation fails, a 400 bad request error should be returned to the user

patriciareinoso · 2025-07-17T11:54:48Z

backend/nfconfig/config.go

-			dg.IpDomainExpanded.Mtu,
-		)
-		ipDomains = append(ipDomains, *ip)
+		for _, ipDomainExp := range dg.IpDomainExpanded {


We can no longer preallocate the capacity of ipDomains in line 239

patriciareinoso · 2025-07-17T11:57:57Z

backend/nfconfig/config.go

+			ip := nfConfigApi.NewIpDomain(
+				ipDomainExp.Dnn,
+				ipDomainExp.DnsPrimary,
+				ipDomainExp.UeIpPool, // Now accessing the correct field from the slice element


what does this comment mean ?

patriciareinoso · 2025-07-17T11:58:41Z

backend/nfconfig/config.go

+				ipDomainExp.Mtu,
+			)
+			ipDomains = append(ipDomains, *ip)
+		}


please add a UT that involves multiple ip-domains in a device group

gab-arrobo · 2025-07-19T15:45:20Z

Closes #257

gab-arrobo · 2025-08-18T01:43:59Z

@anaswarac-dac,
Please resolve conflicts and rebase your PR
Note that the GRPC server was removed (proto directory)

anaswarac-dac added 2 commits July 16, 2025 18:11

feat: Multiple DNN support in single UPF

6a3f48f

Signed-off-by: anaswara <[email protected]>

unnecessary trailing newline removed

64d5ca6

Signed-off-by: anaswara <[email protected]>

anaswarac-dac force-pushed the feat-multiple-dnn branch from 1f0dea8 to 64d5ca6 Compare July 16, 2025 12:42

patriciareinoso suggested changes Jul 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support for Multiple DNNs per Device Group with a Single UPF #389

Support for Multiple DNNs per Device Group with a Single UPF #389

anaswarac-dac commented Jul 16, 2025

Uh oh!

gab-arrobo commented Jul 16, 2025

Uh oh!

patriciareinoso commented Jul 17, 2025

Uh oh!

patriciareinoso left a comment •

edited

Loading

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

patriciareinoso Jul 17, 2025

Uh oh!

gab-arrobo commented Jul 19, 2025

Uh oh!

gab-arrobo commented Aug 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

	IpDomainExpanded []DeviceGroupsIpDomainExpanded `json:"ip-domains,omitempty"`
	IpDomains []DeviceGroupsIpDomainExpanded `json:"ip-domains,omitempty"`

	ipdomains := &requestDeviceGroup.IpDomainExpanded
	ipdomains := requestDeviceGroup.IpDomainExpanded

	for i, ipdomain := range *ipdomains {
	for i, ipdomain := range ipdomains {

		IpDomainName string `json:"ip-domain-name,omitempty"`

		IpDomainExpanded DeviceGroupsIpDomainExpanded `json:"ip-domain-expanded,omitempty"`

Support for Multiple DNNs per Device Group with a Single UPF #389

Are you sure you want to change the base?

Support for Multiple DNNs per Device Group with a Single UPF #389

Conversation

anaswarac-dac commented Jul 16, 2025

Uh oh!

gab-arrobo commented Jul 16, 2025

Uh oh!

patriciareinoso commented Jul 17, 2025

Uh oh!

patriciareinoso left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gab-arrobo commented Jul 19, 2025

Uh oh!

gab-arrobo commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

patriciareinoso left a comment •

edited

Loading

gab-arrobo commented Aug 18, 2025 •

edited

Loading