Skip to content

Fix/okta 920832 support signed nonce factor #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 6, 2025
Merged

Fix/okta 920832 support signed nonce factor #512

merged 9 commits into from
May 6, 2025

Conversation

aditya-okta
Copy link
Contributor

@aditya-okta aditya-okta commented May 2, 2025 •
edited
Loading

Summary

Fixes #488

Type of PR

  • Bug Fix (non-breaking fixes to existing functionality)
  • New Feature (non-breaking changes that add new functionality)
  • Documentation update
  • Test Updates
  • Other (Please describe the type)

Test Information

  • My PR required test updates

Go Version: 1.20
Os Version:
OpenAPI Spec Version: 3.0.3

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I ran make fmt on my code
  • I did not edit any automatically generated files

@aditya-okta aditya-okta force-pushed the fix/OKTA-920832-support-signed_nonce-factor branch 4 times, most recently from 7814e43 to 75bf3e5 Compare May 5, 2025 08:48
@aditya-okta aditya-okta force-pushed the fix/OKTA-920832-support-signed_nonce-factor branch 2 times, most recently from aac7f73 to c696470 Compare May 5, 2025 10:49
@aditya-okta aditya-okta marked this pull request as ready for review May 5, 2025 11:21
@aditya-okta aditya-okta force-pushed the fix/OKTA-920832-support-signed_nonce-factor branch 7 times, most recently from a42e276 to b97b3c1 Compare May 5, 2025 12:39
pranav-okta
pranav-okta reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@pranav-okta pranav-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits and sign your commits.

@aditya-okta aditya-okta force-pushed the fix/OKTA-920832-support-signed_nonce-factor branch from d851da0 to a4d32e9 Compare May 6, 2025 09:55
@aditya-okta aditya-okta force-pushed the fix/OKTA-920832-support-signed_nonce-factor branch from 0600882 to 77b9dd2 Compare May 6, 2025 10:30
@pranav-okta pranav-okta merged commit ce01a4a into master May 6, 2025
4 checks passed
@pranav-okta pranav-okta deleted the fix/OKTA-920832-support-signed_nonce-factor branch May 6, 2025 10:34
@aditya-okta aditya-okta mentioned this pull request May 6, 2025
Closed
@aditya-okta aditya-okta mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranav-okta pranav-okta pranav-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support signed_nonce as a factor type in ListFactors
2 participants
@aditya-okta @pranav-okta