-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Labels
bugSomething isn't workingSomething isn't working
Description
In practice all of the positional properties (clientX/Y
, etc) on pointerEvent
s are floats, not ints (at least in latest Chrome). In the Dom_html
they inherit from mouseEvent
, which describes all of these values as ints. In wasm this fails with a cast error (and in javacript obviously there is a loss of precision in the number).
I think the right fix is to update the types, ideally before the float/int breaking change in js_of_ocaml so that folks can migrate both at the same time. Maybe a closer audit of these values would be good to ensure we aren't missing more?
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working