Skip to content

Conversation

PLAZMAMA
Copy link

@PLAZMAMA PLAZMAMA commented Jan 4, 2025

This pull request aims to solve issue #17 without the need of using the --lua-version=5.1 argument for local testing.

@mfussenegger
Copy link
Collaborator

Thanks but this has the issues outlined in #19

@PLAZMAMA
Copy link
Author

PLAZMAMA commented Jan 4, 2025

I see, thanks for taking your time to informing me of where this has been discussed before. I rashly assumed that this issue was only discussed in issue #17 as it is still open. Is there a reason that issue is still open? From what I see, the README mentions the fix for this(although not as clearly as I would liked it to be).

@mfussenegger
Copy link
Collaborator

Is there a reason that issue is still open?

Not really, I think it can be closed.

although not as clearly as I would liked it to be.

If you have a concrete suggestion to clarify it a PR for that is welcome.

@PLAZMAMA PLAZMAMA mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants