-
Notifications
You must be signed in to change notification settings - Fork 531
feat: add custom metadata support and HTTP response metadata #2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cablehead
wants to merge
9
commits into
nushell:main
Choose a base branch
from
cablehead:http-response-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdncred
pushed a commit
to nushell/nushell
that referenced
this pull request
Oct 8, 2025
## Release notes summary - What our users need to know This PR adds two related features: 1. Custom metadata via `metadata set --merge`: Attach arbitrary metadata to pipeline data: ```nushell "data" | metadata set --merge {custom_key: "value"} | metadata | get custom_key ``` 2. Automatic HTTP response metadata: All HTTP commands now attach response metadata under `http_response`: - `status` - HTTP status code - `headers` - Response headers as `[{name, value}, ...]` - `urls` - Redirect history Access metadata after the response completes: ```nushell http get https://api.example.com | metadata | get http_response.status # => 200 ``` Or access metadata while streaming the response body using `metadata access`: ```nushell http get https://api.example.com/events.jsonl | metadata access {|meta| if $meta.http_response.status != 200 { error make {msg: "failed"} } else { } } | lines | each { from json } | where event_type == "error" ``` Unlike `--full`, which consumes the entire response body, this allows streaming while accessing metadata. ## Breaking changes `collect` now removes `FilePath` data_source even when `content_type` is set. Previously: both preserved. Now: `content_type` preserved, `FilePath` cleared. corresponding PR: nushell/nushell.github.io#2051
github is being weird, there should be one more commit on this PR: main...cablehead:nushell.github.io:http-response-metadata ![]() |
i'm not sure what's going on with the commits. that's weird. |
github was struggling this morning; looks like that commit has been pulled in now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding PR: nushell/nushell#16821