Fix kvsort/kvselect nan behavior and added tests for mixed nan/inf arrays #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-devulap
approved these changes
Feb 20, 2025
r-devulap
reviewed
Feb 20, 2025
| } | ||
|
|
||
| // Handle the remainders once we have less than 1 vector worth | ||
| while (ii < jj) { |
There was a problem hiding this comment.
Could have combined this in the main loop with a masked load, but this is fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I identified two bugs related to the handling of nans in the kvsort/kvselect logic.
This patch should fix both of these issues, and it adds a test with mixed inf/nan arrays for all of the qsort/kvsort tests. From my testing, it seems to have a negligible performance impact.