Skip to content

Conversation

WilliamTambellini
Copy link
Contributor

@WilliamTambellini WilliamTambellini commented Aug 23, 2024

Add a lib_type build option.
Fixing linking failure with libbenchmark 1.7 (could need pthreads)

Add an option to select build  lib (shared or static).
Fixing linking failure with libbenchmark 1.7 (could need pthreads).
@WilliamTambellini WilliamTambellini changed the title Link benchexe with treads dep Add option to choose the lib type (shared or static) Aug 26, 2024
@WilliamTambellini
Copy link
Contributor Author

WilliamTambellini commented Aug 26, 2024

Voila @r-devulap, added a lib_type meson build option.
Review please.

Copy link

@matiaslin matiaslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this added flexibility to the library type sounds like a great idea to me.

Copy link
Member

@r-devulap r-devulap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will let the Ci pass before merging. Might be useful to have one of the CI tests build with the new option.

@r-devulap
Copy link
Member

Closes #161 and #163

@r-devulap r-devulap merged commit 169dc6e into numpy:main Sep 4, 2024
9 of 11 checks passed
@r-devulap
Copy link
Member

Thanks @WilliamTambellini!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

benchexe linking failure with recent libbenchmark Add build option to build a static lib
3 participants