Skip to content

Conversation

yixuan
Copy link
Contributor

@yixuan yixuan commented Jul 26, 2024

This pull request fixes some mistakes in the previous documentation, and reflects recent API changes.

  1. AVX2 now also has argsort, argselect, and key-value sort.
  2. Adds the missing argument k in qselect and partial_qsort.
  3. The version of argsort that returns a std::vector has been removed. Similar for argselect.
  4. Fixes the template parameters in avx512_qsort_kv.
  5. The sample code needs to include some xss-common-* headers to compile.

Copy link
Member

@r-devulap r-devulap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing!

@r-devulap r-devulap merged commit 87486d1 into numpy:main Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants