Skip to content

Maxwell/Pascal GPU support and crash fix #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Maxwell/Pascal GPU support and crash fix #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c37b5b
update llama.cpp to enable Nvidia Pascal GPUs
cebtenzzre Jan 31, 2024
445037d
chat: fix crash caused by calling clearChats too early
cebtenzzre Jan 31, 2024
e84e598
actually delete chats in clearChats()
cebtenzzre Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gpt4all-backend/llama.cpp-mainline
Open in desktop
Submodule llama.cpp-mainline updated 2 files
+1 −3 ggml-kompute.cpp
+1 −1 kompute
1 change: 1 addition & 0 deletions gpt4all-chat/chatlistmodel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ class ChatListModel : public QAbstractListModel
m_newChat = nullptr;
m_serverChat = nullptr;
m_currentChat = nullptr;
for (auto * chat: m_chats) { delete chat; }
m_chats.clear();
}

Expand Down
4 changes: 3 additions & 1 deletion gpt4all-chat/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,11 @@ int main(int argc, char *argv[])
}
#endif

int res = app.exec();

// Make sure ChatLLM threads are joined before global destructors run.
// Otherwise, we can get a heap-use-after-free inside of llama.cpp.
ChatListModel::globalInstance()->clearChats();

return app.exec();
return res;
}