Skip to content

fix typo #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix typo #1697

merged 1 commit into from
Nov 30, 2023

Conversation

moritztim
Copy link
Contributor

Describe your changes

Fixed a lil typo in an error message

Issue ticket number and link

n/a

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

n/a

Steps to Reproduce

n/a

Notes

@moritztim
Copy link
Contributor Author

I can't edit the labels.

barnett-yuxiang
barnett-yuxiang reviewed Nov 30, 2023
View reviewed changes
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing such a long line of code is not very friendly to the reading experience

@moritztim
Copy link
Contributor Author

I added one word.

@cebtenzzre cebtenzzre merged commit 012f399 into nomic-ai:main Nov 30, 2023
@moritztim moritztim deleted the typo branch December 1, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

+1 more reviewer

@barnett-yuxiang barnett-yuxiang barnett-yuxiang left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moritztim @barnett-yuxiang @cebtenzzre