use viewer certificate for cloud front #361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonLdj
force-pushed
the
cf-use-viewerCertificate
branch
from
23a6c14 to
9e0159c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow specifying
securityPolicyandsslMethodboth when using createSiteWithCloudfront or createSiteFromHostedZone.Also,
aliasConfigurationis deprecated and it is advised to useViewerCertificateinstead.one open issue is,
securityPolicyandsslMethodignored if certificateARN was not given when using createSiteWithCloudfront.Seems like with ViewerCertificate we must have some certificate to change those settings.
Later I would like to enable specifying certificateARN when using createSiteFromHostedZone (instead of always creating one)