Skip to content

Hide share button in portrait mode to save space #15714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

Hide share button in portrait mode to save space #15714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@
import android.accounts.OperationCanceledException;
import android.annotation.SuppressLint;
import android.app.Activity;
import android.content.ComponentCallbacks;
import android.content.ContentValues;
import android.content.res.ColorStateList;
import android.content.res.Configuration;
import android.content.res.Resources;
import android.graphics.Color;
import android.graphics.drawable.Drawable;
Expand Down Expand Up @@ -198,6 +200,16 @@ public OCFileListAdapter(
// initialise thumbnails cache on background thread
ThumbnailsCacheManager.initDiskCacheAsync();
isRTL = DisplayUtils.isRTL();

activity.registerComponentCallbacks(new ComponentCallbacks() {
@Override
public void onConfigurationChanged(@NonNull Configuration newConfig) {
notifyDataSetChanged(); // force update of orientation-dependent layout (e.g. share button visibility)
}
@Override
public void onLowMemory() {
}
});
}

public boolean isMultiSelect() {
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/com/owncloud/android/ui/adapter/OCFileListDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
package com.owncloud.android.ui.adapter

import android.content.Context
import android.content.res.Configuration
import android.graphics.Color
import android.os.AsyncTask
import android.view.View
Expand Down Expand Up @@ -261,6 +262,7 @@ class OCFileListDelegate(
// shares
val shouldHideShare = (
hideItemOptions ||
context.resources.configuration.orientation == Configuration.ORIENTATION_PORTRAIT ||
!file.isFolder &&
file.isEncrypted ||
file.isEncrypted &&
Expand Down