fix: upload cancel #15712
Open
fix: upload cancel #15712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
commented
Sep 29, 2025
alperozturk96
commented
Sep 29, 2025
alperozturk96
commented
Sep 30, 2025
|
|
||
| // need to update now table in mUploadsStorageManager, | ||
| // since the operation will not get to be run by FileUploader#uploadFile | ||
| uploadsStorageManager.removeUpload(accountName, remotePath) |
There was a problem hiding this comment.
@tobiasKaminsky Why do we have two different place for uploads?
ProviderTableMeta.UPLOADS_TABLE_NAME and CONTENT_URI_UPLOADS
alperozturk96
force-pushed
the
fix/cancel-upload
branch
2 times, most recently
from
36a27de to
4d30858
Compare
|
/backport to stable-3.34 |
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
fix/cancel-upload
branch
from
4d30858 to
f676bd8
Compare
|
test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15712-Unit-test-08-28 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15712.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the user presses Cancel during an upload, the ongoing or pending upload must be properly cancelled and reflected in the upload list.
Scenarios
From Notification:
When the user presses the cancel button in the notification, the ongoing upload should stop immediately.
From Upload List Screen:
When the user cancels from the upload list, the corresponding upload should also be stopped.
Expected Behavior
How to Test