Skip to content

Conversation

chagaiB
Copy link

@chagaiB chagaiB commented Sep 16, 2025

This PR fixes a crash caused by URLDecoder when filenames contain invalid '%' patterns (like "65% on Sonic Wave").
It adds a safeUrlDecode() method that catches IllegalArgumentException and returns the original string instead of crashing.

Copy link

github-actions bot commented Oct 1, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Fix crash when decoding filenames with invalid % characters

Signed-off-by: chagaiB <[email protected]>
This commit adds a safeUrlDecode() helper that prevents IllegalArgumentException
when filenames contain invalid % patterns (like "65% on Sonic Wave").
Instead of crashing, the filename is returned as-is and the app continues normally.


Signed-off-by: chagaiB <[email protected]>
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for the PR. I can't test it. It is not building.

Screenshot 2025-10-01 at 09 40 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants