When deleting image in preview activity, move to the next image #11919
Conversation
Instead of closing the preview after the deletion of an image file, the next image is shown. This allows to conveniently go through a list of images and delete unwanted ones, without the flow being interrupted. Closes nextcloud#11918 Signed-off-by: Philipp Hasper <[email protected]>
|
@tobiasKaminsky is this something worth pursuing? Anything I shoulf add to get it merged? |
|
I would say it is worth perusing, also looping in @jancborchardt for feedback from a designer's perspective on the behavior introduced with this change. |
There was a problem hiding this comment.
Works well and feels intuitive to use!
One incredibly minor thing I noticed is that the transition between the Wait a moment... dialogue and the next image opening can be quite harsh. It's also possible that my emulator is acting up. Either way, I'd suggest merging this as is and maybe addressing this later.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Instead of closing the preview after the deletion of an image file, the next image is shown. This allows to conveniently go through a list of images and delete unwanted ones, without the flow being interrupted.
Closes #11918