-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Labels
Description
Steps to reproduce
- have multiple images in a folder
- click on one, to open slide show
- delete one
- --> folder listing is shown
Expected behaviour
- have multiple images in a folder
- click on one, to open slide show
- delete one
- --> another image is shown
Actual behaviour
The slideshow is left and the parent folder is shown again.
Nextcloud android app version
3.32.3
. Also reproducible on master
Additional information
This functionality seems to break from time to time:
- Initially it was fixed in When deleting image in preview activity, move to the next image #11919
- The logic was improved and made more explicit in pull/13016
- Somewhere it regressed again
- Was fixed again in showDirectoryWhenDeletionCompleted set to false? #14646
- Then it broke again. I suspect Finish PreviewImageActivity After Image Deletion #14782 , which added
finishPreviewImageActivity()
to theRemoveFilesDialogFragment
, so thatPreviewImageActivity::onRemoteOperationFinish()
with the responsible logic is never called
On a secondary notice, the position handling in PreviewImageActivity::onRemoteOperationFinish()
also seems to have some bugs, which we could fix in the same go:
- When deleting the first image in a folder, it doesn't jump to the second, but the third image. If there is no third, an empty view appears
- Sometimes (don't know yet, when) it also jumps out of the slideshow.
Lastly all this regressing and being faulty indicates we need an automated test for this.