Skip to content

Fix RxResult method mapping #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Fix RxResult method mapping #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/types/result-rx.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ res.records().subscribe({
error: error => console.log(`records error: ${error}`)
})

res.summary().subscribe({
res.consume().subscribe({
next: value => console.log(`summary: ${value}`),
complete: () => console.log('summary complete'),
error: error => console.log(`summary error: ${error}`)
Expand Down
6 changes: 3 additions & 3 deletions test/types/session-rx.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const result1: RxResult = rxSession.run('RETURN 1')
result1.keys().subscribe(keysObserver)
result1.records().subscribe(recordsObserver)
result1
.summary()
.consume()
.pipe(
concat(close1),
catchError(err => close1.pipe(concat(throwError(err))))
Expand All @@ -120,7 +120,7 @@ const result2: RxResult = rxSession.run('RETURN $value', { value: '42' })
result2.keys().subscribe(keysObserver)
result2.records().subscribe(recordsObserver)
result2
.summary()
.consume()
.pipe(
concat(close1),
catchError(err => close1.pipe(concat(throwError(err))))
Expand All @@ -135,7 +135,7 @@ const result3: RxResult = rxSession.run(
result3.keys().subscribe(keysObserver)
result3.records().subscribe(recordsObserver)
result3
.summary()
.consume()
.pipe(
concat(close1),
catchError(err => close1.pipe(concat(throwError(err))))
Expand Down
4 changes: 2 additions & 2 deletions test/types/transaction-rx.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ const tx: RxTransaction = dummy
const result1: RxResult = tx.run('RETURN 1')
result1.keys().subscribe(keysObserver)
result1.records().subscribe(recordsObserver)
result1.summary().subscribe(summaryObserver)
result1.consume().subscribe(summaryObserver)

const result2: RxResult = tx.run('RETURN $value', { value: '42' })
result2.keys().subscribe(keysObserver)
result2.records().subscribe(recordsObserver)
result2.summary().subscribe(summaryObserver)
result2.consume().subscribe(summaryObserver)

tx.commit()
.pipe(concat(of('committed')))
Expand Down
2 changes: 1 addition & 1 deletion types/result-rx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ declare interface RxResult {

records(): Observable<Record>

summary(): Observable<ResultSummary>
consume(): Observable<ResultSummary>
}

export default RxResult