Fix HELLO message RoutingContext and send bookmarks in the ROUTE message #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The routing context was missing information about the initial routing server. This information is important for the server side routing.
This important in the case of a creation of a new database to make sure the database is running in all the clusters nodes returned. This change also skips a test which depends on feature which doesn't exists on the javascript driver.
bigmontz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routing context was missing information about the initial routing server. This information is important for the server side routing.
The bookmarks in the ROUTE message are important in the case of a creation of a new database to make sure the database is running in all the clusters nodes returned.