Skip to content

Conversation

bigmontz
Copy link
Contributor

Fix the way the url is generated during the stress test enabling to use configurations came from the test environment.
Skipping the non-cluster-safe stress test commands to avoid unstable behaviours and flaky tests.

Fix the way the url is generated during the stress test enabling to use configurations came from the test environment.
Skipping the non-cluster-safe stress test commands to avoid unstable behaviours and flaky tests.
@bigmontz bigmontz force-pushed the 4.3-tunning-stress-test branch from 57e19b9 to 60fa032 Compare December 14, 2020 14:49
@bigmontz bigmontz force-pushed the 4.3-tunning-stress-test branch from 60fa032 to 56c702a Compare December 14, 2020 14:56
@bigmontz bigmontz requested review from 2hdddg and zhenlineo and removed request for zhenlineo December 14, 2020 15:16
'Neo.ClientError.Database.DatabaseNotFound'
const SYSTEM_DB_NAME = 'system'
const DEFAULT_DB_NAME = ''
const DEFAULT_DB_NAME = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this discovered with new default db test? I didn't see any failure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered it when I test against clusters using testkit locally.

@bigmontz bigmontz merged commit 26b8b97 into neo4j:4.3 Dec 15, 2020
@bigmontz bigmontz deleted the 4.3-tunning-stress-test branch December 15, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants