Skip to content

Export Integer type #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2019
Merged

Export Integer type #435

merged 2 commits into from
Jan 17, 2019

Conversation

joknelid
Copy link
Contributor

@joknelid joknelid commented Dec 5, 2018

No description provided.

lutovich
lutovich approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@lutovich lutovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Having a test in types.test.js that accesses the exported type as neo4j.types.Integer would be nice. Just to make sure it's not removed accidentally during a refactoring.

@joknelid
Copy link
Contributor Author

joknelid commented Dec 5, 2018

@lutovich Added a test now

@ali-ince ali-ince merged commit 9a4fde2 into neo4j:1.7 Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lutovich lutovich lutovich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joknelid @lutovich @ali-ince