Couple fixes for release of broken connections to the pool #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to resolve a pending acquisition request can be made when connection is returned back to the pool. It will only be made when there exists a pending acquisition request and returned connection is valid. It was previously possible for the release operation to deque a pending acquisition request and forget about it, even when the returned connection was invalid. This made the acquisition request either fail with acquisition timeout or with "Cannot read property 'filter' of undefined" error. Later happened because subsequent release operation for the same key removed the array of pending acquisition requests. This commit fixes the problem by making release operation only deque an acquisition request when new request can be acquired.
Release operation discards the connection if it is broken. It also tries to resolve a pending acquisition request, if any. In order to this it tries to execute a promise-free internal acquire that immediately returns an available resource or creates a new one, if possible. New resource can only be created if pool is not at its maximum capacity. Previously, release operation only decremented the active connection counter at the end. This made it impossible to create a new connection when broken one is returned. This commit fixes the problem by making `Pool#_release()` decrement the active counter after connection has been either added to the list of idle connections or discarded because it turned out to be broken.
ali-ince
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304