Skip to content

Expose onComplete method from Driver. #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2016
Merged

Expose onComplete method from Driver. #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cdf0c8
Exposed onComplete method from Driver.
eve-bright Aug 31, 2016
acfe28e
Removed transpiled files from pr
eve-bright Aug 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/v1/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@ class _ConnectionStreamObserver extends StreamObserver {
this._hasFailed = true;
}
}
onCompleted(message) {
if(this._driver.onCompleted) {
this._driver.onCompleted(message);
}
}
}

let USER_AGENT = "neo4j-javascript/" + VERSION;
Expand Down
13 changes: 13 additions & 0 deletions test/v1/driver.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,17 @@ describe('driver', function() {
// When
driver.session();
});

it('should indicate success early on correct credentials', function(done) {
// Given
var driver = neo4j.driver("bolt://localhost", neo4j.auth.basic("neo4j", "neo4j"));

// Expect
driver.onCompleted = function (meta) {
done();
};

// When
driver.session();
});
});