remove redundant dependencies #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hermannm Thank you, this is a great improvement! It's greatly appreciated. I've got a bit of work to do on the GH workflow, it hasn't been touched in a while and has deprecation warnings for old versions of actions, and then I'll tag and release. Thank you for all the work. Do you have any interest in being added as a collaborator on the repo? |
@neilotoole Sure, I'd be delighted to! |
|
@neilotoole Great to hear! I'll check it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
While implementing #21, I noticed that the library appeared to have some redundant dependencies. As I like to avoid transitive dependencies where possible, I thought I'd propose these changes.
Changes
IsColorTerminalto no longer depend ongolang.org/x/term, since we already depend ongo-isattyand can just use thatgo-isattyto the newest version, which also lets us use a tagged version forgolang.org/x/sysasciiValidandasciiValidPrintfunctions, to avoid the dependency onsegmentio/encoding(outside of tests, but that doesn't affect transitive dependencies)segmentio, I thought it was a shame that just these two functions brought that whole dependencySorry if I should have raised an issue about this first, but hope you might appreciate it anyway!