Skip to content

Fix: The Description field of VersionOptionFromMemberAttribute is unused #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Fix: The Description field of VersionOptionFromMemberAttribute is unused #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/CommandLineUtils/Attributes/VersionOptionFromMemberAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ internal CommandOption Configure(CommandLineApplication app, Type type, Func<obj
};
}

return app.VersionOption(Template, shortFormGetter, longFormGetter);
var option = app.VersionOption(Template, shortFormGetter, longFormGetter);
Configure(option);
return option;
}
}
}
15 changes: 15 additions & 0 deletions test/CommandLineUtils.Tests/VersionOptionFromMemberAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

using System;
using System.Linq;
using Xunit;

namespace McMaster.Extensions.CommandLineUtils.Tests
Expand Down Expand Up @@ -67,5 +68,19 @@ public void ThrowWhenMemberDoesNotExist()
});
Assert.Equal(Strings.NoPropertyOrMethodFound("Version", typeof(MissingMethod)), ex.Message);
}

[VersionOptionFromMember(Description = "42")]
private class Description
{
}

[Fact]
public void GetsDescriptionFromOption()
{
var app = new CommandLineApplication<Description>();
app.Conventions.UseVersionOptionFromMemberAttribute();

Assert.Equal("42", app.Options.First().Description);
}
}
}