Skip to content

Conversation

TheConstructor
Copy link
Contributor

Currently the most reliable way to use a custom parser and still use property-attributes is implementing an attribute-class that also implements IConvention to register the custom parser, as UseAttributes is first in UseDefaultConventions.

Currently the most reliable way to use a custom parser and still use property-attributes is implementing an attribute-class that also implements IConvention to register the custom parser, as UseAttributes is first in UseDefaultConventions.
Copy link
Owner

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense why you would need this. Could we add a unit test asserting the use case this change is meant to support?

@natemcmaster natemcmaster added this to the 3.1.0 milestone Nov 7, 2020
@TheConstructor
Copy link
Contributor Author

Been some days… as far as I remember the only option to previously register a parser for options detected through attributes was as in test ItParsesUsingCustomParserFromAttribute. The other two (which occur to be more obvious to me) only work after my change.

@TheConstructor TheConstructor force-pushed the feature/late-bind-parser branch from 6e26fd2 to e4785cc Compare November 9, 2020 07:07
Copy link
Owner

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheConstructor !

@natemcmaster natemcmaster merged commit 760247d into natemcmaster:main Nov 11, 2020
@TheConstructor TheConstructor deleted the feature/late-bind-parser branch April 3, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants