Skip to content

Escape empty arguments. #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Escape empty arguments. #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CommandLineUtils/Utilities/ArgumentEscaper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ private static string EscapeSingleArg(string arg)
{
var sb = new StringBuilder();

var needsQuotes = ContainsWhitespace(arg);
var needsQuotes = arg.Length == 0 || ContainsWhitespace(arg);
var isQuoted = needsQuotes || IsSurroundedWithQuotes(arg);

if (needsQuotes)
Expand Down
1 change: 1 addition & 0 deletions test/CommandLineUtils.Tests/ArgumentEscaperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public class ArgumentEscaperTests
[InlineData(new[] { @"C:\Program Files\dotnet\" }, @"""C:\Program Files\dotnet\\""")]
[InlineData(new[] { @"backslash\""preceedingquote" }, @"backslash\\\""preceedingquote")]
[InlineData(new[] { @""" hello nate """ }, @"""\"" hello nate \""""")]
[InlineData(new[] { "one", "", "three" }, "one \"\" three")]
public void EscapesArguments(string[] args, string expected)
{
Assert.Equal(expected, ArgumentEscaper.EscapeAndConcatenate(args));
Expand Down