fix #207: Additional command names are case-sensitive #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private List<Action<ParseResult>> _onParsingComplete; | ||
| internal readonly Dictionary<string, PropertyInfo> _shortOptions = new Dictionary<string, PropertyInfo>(); | ||
| internal readonly Dictionary<string, PropertyInfo> _longOptions = new Dictionary<string, PropertyInfo>(); | ||
| private readonly HashSet<string> _names = new HashSet<string>(StringComparer.Ordinal); |
There was a problem hiding this comment.
Rather than add a new API, I think I would rather just keep the code as is, but change this to StringComparer.OrdinalIgnoreCase. This was a new feature in 2.3 which hasn't seen much usage yet. Now that I think about it, I doubt many users would want subcommands to vary by case, and in 2.2 subcommand name matching was already case-insensitive.
|
Thanks for making the PR. If you can update with my suggestion and make sure the tests are passing, I'll be happy to get this into a patch soon. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes issue #207. I can modify it if needed.
Best regards