Skip to content

Conversation

TheConstructor
Copy link
Contributor

@TheConstructor TheConstructor commented Dec 17, 2018

I am not 100% sure, but to me it feels that Thread.FromResult should be synchronous and I don't know if it is enough to use await deeper down the rabbit hole. Thus this will try to make the *Async methods do await on other *Async methods until Invoke/InvokeAsync may finally be a sync or async method.

The cancellationToken in CommandLineService.RunAsync requires more changes and thus deserves a separate pull-request.

@TheConstructor TheConstructor force-pushed the feature/async-all-the-way branch from b7c1e70 to fa1349b Compare December 17, 2018 20:31
@TheConstructor TheConstructor changed the title Async all the way through WIP Async all the way through Dec 17, 2018
@natemcmaster
Copy link
Owner

I'm going to hold off on this change for now. I'd like to address #153 and #111 in 3.0 by taking a breaking change which switches execution to be async be default, with synchronous helpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants