feat: make oneOf relation required if non-nullable #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkolotov
force-pushed
the
feat/required-oneof-relations
branch
from
430ec55 to
ca448f9
Compare
|
@kettanaito do you by any chance have time to review this PR? |
timkolotov
force-pushed
the
feat/required-oneof-relations
branch
from
ca448f9 to
8ff30ad
Compare
|
@kettanaito it's been a year, but the issue is still present and I hope this MR has a chance to be merged 🙂 |
|
Any news on this? |
|
Now what? Also facing this undefined issue with oneOf |
Merged
Released: v1.0.0 🎉This has been released in v1.0.0. Get these changes by running the following command: Predictable release automation by Release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #269 by making
oneOfrelation required (throwing an error) unless the field is explicitly set to nullable.