-
-
Notifications
You must be signed in to change notification settings - Fork 36k
Add support for using BC5 and EAC_RG compressed textures as normal maps. #31695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
castano
wants to merge
13
commits into
mrdoob:dev
Choose a base branch
from
Ludicon:normalmap-projectz
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−3
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6f87f91
Add NormalMapNode projectZ attribute.
castano 0426e41
Add unpack normal helpers to Packing.js
castano 6e7478a
Add normal packing mode constants to constants.js
castano 1a4e77f
Import normal packing mode constants.
castano dca8fc4
Rename projectZ to unpackNormal.
castano 31195ee
Material sets unpackNormal attribute based on normal map user data at…
castano 3d843f6
Fix lint errors.
castano 5413f13
Fix linter error.
castano 344bec8
Replace unpackNormal functions with reconstructZ.
castano 2e9e502
Merge branch 'dev' into normalmap-projectz
castano 0e25686
Apply suggested renaming.
castano cdcabdf
Rename unpackNormalZ and update invocation.
castano 407e673
Or better, keep unpackNormal function and rename attribute.
castano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.