Warmup and cosine annealing warm restarts combine sequentially #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanlint
approved these changes
Nov 22, 2021
merge dev into warmup_cosine_restarts
|
It seems some of the tests were not passed (despite only changing 2 lines of code). I updated composer to version 0.3, so hopefully this will pass all the tests. |
Delete experiment yamls
coryMosaicML
pushed a commit
to coryMosaicML/composer
that referenced
this pull request
Feb 23, 2022
…cml#99) * warmup and cosine restarts combined nicely * alphabetical import * change import order for linting * test * Delete experiments directory Delete experiment yamls * clean up .gitignore * run isort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current mosaicml/composer dev branch, warm up interferes with some learning rate schedulers including cosine annealing warm restarts.
In the following PR, I've changed one line of code in
ComposedSchedulerthat ensures that the cosine annealing warm restarts scheduler only begins after warmup:self.delay_schedulers = [CosineAnnealingLR, ExponentialLR, CosineAnnealingWarmRestarts]I've also tested this on a separate branch